typo README.md / update NoGatewayAvailableException.php #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overtrue
reviewed
Jan 22, 2024
| /** | ||
| * @return array | ||
| */ | ||
| public function getAllResults() |
There was a problem hiding this comment.
这个方法的作用是啥？如果仅仅是列出每个网关的报错，那么只有 message 恐怕不太具有多大意义，我的建议是这块交由应用自身去处理，想要记日志也好，报错信息也好，由应用自身决定展示成什么样。
There was a problem hiding this comment.
作用是在当前配置的所有网关都失败的情况下，获取所有网关失败的原因。
getResults 方法也可以获取所有的网关错误，但是不同的网关错误信息字段名是不一致的，交由应用自身去处理的话逻辑重复太多了。
不过我觉的你说的也有道理...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、修正readme中创蓝网关类名示例
2、增加获取所有网关异常 message